Fix-Verify-Installed-Packages #44587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes package verification logic by changing the package name normalization from uppercase to lowercase, which aligns with Python packaging standards (PEP 503). It also improves error handling to prevent KeyError exceptions when packages are completely missing.
Key changes:
- Changed package name normalization from
.upper()to.lower()for both installed and expected package dictionaries - Updated error logging to use
.get()with a default value instead of direct dictionary access
Contributor
Author
|
/check-enforcer override |
mccoyp
approved these changes
Jan 8, 2026
Member
mccoyp
left a comment
mccoyp
left a comment
There was a problem hiding this comment.
The casing change is consistent for both sets being compared, and seems like it would possibly prevent the issue in your pipeline run. Change looks good to me
weshaggard
approved these changes
Jan 9, 2026
6 tasks
kdestin
added a commit
to kdestin/azure-sdk-for-python
that referenced
this pull request
Jan 9, 2026
This reverts commit e4b5384.
weshaggard
pushed a commit
that referenced
this pull request
Jan 9, 2026
…ation in latestdependencies (#44597) * Revert "Fix-Verify-Installed-Packages (#44587)" This reverts commit e4b5384. * fix: Apply PEP 503 package name normalization before verifying packages This resolves issues where packages, like ruamel.yaml, may appear under different names across the set of expected and installed package sets (e.g. `ruamel-yaml` and `ruamel.yaml`) despite both names referring to the same package per PEP 503.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created to fix Evaluation Release Pipeline. It's failing with following error.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5729245&view=logs&j=a439c15f-05d2-526c-6deb-52d41b9c47ce&t=dc324d6b-dde8-5f75-c0a6-02068c86ab77&s=b49e7e65-b64b-557c-018e-3fd79c15ded6